Change FEMSWEEP to read in file for mesh data#599
Conversation
|
Does reading the data also affect the problem size, number of elements, etc? |
…s, and DOFs for each face side.
|
How big can meshes get? I'm wondering how the meshes will impact the repo size. |
| } | ||
|
|
||
| template < typename T > | ||
| void FEMSWEEP::readIndexArray(VariantID vid, std::ifstream & file, T*& arr, Index_type expectedsize, std::string arrname) |
There was a problem hiding this comment.
This can probably be a free function, probably in an unnamed namespace.
There was a problem hiding this comment.
I can move it if some other kernel is going to use it, but I think the femsweep is the only one that requires something like this at the moment so I'll keep it the way it is.
There was a problem hiding this comment.
I just mean that it doesn't use any of the kernel's state, it could be a free function. Its not a big deal, but its probably best practice if that's true to make it a free function.
|
@rhornung67 How about I revert this PR such that there is only one small mesh? That way the meshes won't show up in the git branches and history. After that, we can create another repo to store the larger meshes. |
|
@rchen20 , you can also squash merge |
Thanks, but I don't think squash merging will prevent people from downloading all the meshes on every |
Ah I see, thanks for explaining. Sure I'm in favor of your original proposition |
a5e122b to
0a3a53a
Compare
Summary