Cache extractions of unsuccessful runs; allow extraction persistence #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nightlark
reviewed
Jul 21, 2025
✅ No SBOM Changes DetectedFor commit ba0a98d (Run 16634696818) |
WorkingRobot
force-pushed
the
cache-decomp
branch
from
74cf71c to
a438380
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nightlark
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will allow caching extractions of unsuccessful runs (by default) and allow extractions to be persisted across runs (opt-in).
Proposed changes
The config file for storing persisted directories is in
%TEMP%/.surfactant_extracted_dirs.json(or the relevant directory in other platforms. Being located in the same folder as the temp directories, it should allow the end user to clear their temp directory without issue. The config optiondecompression.cache_extractions(True by default) enables the behavior in this PR, whiledecompression.persist_extractions(False by default) enables the behavior even when Surfactant exits successfully. This PR is especially nice when dealing with large archives (i.e. a 5 GB .wim file that Surfactant will be able to handle in #450 that takes 2 hours to extract).