Motorola SREC and Intel HEX file extraction support #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🆕 New Folders (1)
🧪 SBOM Results (2/17)
|
WorkingRobot
requested changes
Dec 16, 2025
Member
WorkingRobot
left a comment
WorkingRobot
left a comment
There was a problem hiding this comment.
LGTM except for a few spots. I wonder if we should refactor this and the file decompression to compartmentalize the cache handling system?
Comment on lines
+485
to
+499
| default_value = False | ||
| else: | ||
| # Have to convert from string to Boolean | ||
| default_value = default_value.lower() == "true" | ||
| self.value = self.__config_manager.get(self.plugin_name, self.info.name, default_value) | ||
| self.value = str( | ||
| self.__config_manager.get(self.plugin_name, self.info.name, default_value) | ||
| ) | ||
| elif self.info.type_ == "int": | ||
| self.input_field = textual.widgets.Input(type="integer") | ||
| default_value = self.info.default | ||
| if default_value is None: | ||
| default_value = 0 | ||
| self.value = str( | ||
| self.__config_manager.get(self.plugin_name, self.info.name, int(default_value)) | ||
| ) |
Member
There was a problem hiding this comment.
Should this TUI code be in a separate PR?
|
|
||
| MAX_FILE_SIZE = int(ConfigManager().get("srec_hex", "max_file_size", 1000000)) | ||
| STRIP_LEADING_ZEROS = bool(ConfigManager().get("srec_hex", "strip_leading_zeros", False)) | ||
| EXTRACT_DIR = pathlib.Path(ConfigManager().get("srec_hex", "output_path", "")).absolute() |
Member
There was a problem hiding this comment.
EXTRACT_DIR should imitate file_decompression.py and use tempfile.gettempdir() as a default. pathlib.Path("").absolute() uses the current working directory.
|
|
||
| def get_first_and_last_address(data: List[WriteInfo]) -> Tuple[int, int]: | ||
| # Arbitrarly large number so smaller addresses will always compare true | ||
| first_address = 2 << 65 |
Member
There was a problem hiding this comment.
Probably fine? Feels wrong to have a magic number here.
|
|
||
| _base_path = pathlib.Path(__file__).parent.absolute() | ||
| _data_dir = os.path.join(_base_path, "..", "data", "binary") | ||
| _expected_output_loc = os.path.join(_base_path, "..", "data", "msitest_no1", "test.msi") |
Member
There was a problem hiding this comment.
Might be a good idea to move the msi into the data/binary folder so we can separate the msi test files from the srec/hex test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will add support for extracting files from Motorola SREC and Intel HEX files into a user-specified directory. This address #257.