Fix: erroneous creation of properly closed mark#355
Merged
KIwabuchi merged 1 commit intollnl:developfrom Jul 10, 2025
Merged
Conversation
This was referenced Jun 26, 2025
bigerl
approved these changes
Jun 26, 2025
Contributor
bigerl
left a comment
bigerl
left a comment
There was a problem hiding this comment.
Thx for fixing this. Changes look good and solve the problem. Design with the empty path as reserved value is fine and clearly documented in the comment at the field. If a more expressive form is wanted, we could also use a std::optional<std::filesystem::path> for m_mark_path.
Member
|
I haven't tested the move assignment of |
Member
|
Removed move assignment and move constructor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the
properly_closed_markwould create its mark on the filesystem even if it was not opened correctly.Btw: Did you test that move assigning the
manager_kernelworks correctly?I didn't look deeply into it but the ctors/operators seem to be defaulted in a lot of places which usually does not work properly with such complex things, especially if they contains trivial datatypes (which are just copied).