Skip to content

Removing check for no elements on rank #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswartz92 merged 2 commits into from
Mar 10, 2026
Merged

Removing check for no elements on rank #1549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
016daa6
removing no element check
kswartz92 Mar 9, 2026
d3bd121
Merge branch 'develop' into swartz10/removeNoElementOnRankCheck
btalamini Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/smith/physics/mesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ Mesh::Mesh(const std::string& meshfile, const std::string& meshtag, int refine_s
{
auto meshtmp = mesh::refineAndDistribute(buildMeshFromFile(meshfile), refine_serial, refine_parallel, comm);
mfem_mesh_ = &smith::StateManager::setMesh(std::move(meshtmp), mesh_tag_);
errorIfRankHasNoElements();
createDomains();
}

Expand All @@ -33,7 +32,6 @@ Mesh::Mesh(mfem::Mesh&& mesh, const std::string& meshtag, int refine_serial, int
{
auto meshtmp = smith::mesh::refineAndDistribute(std::move(mesh), refine_serial, refine_parallel, comm);
mfem_mesh_ = &smith::StateManager::setMesh(std::move(meshtmp), mesh_tag_);
errorIfRankHasNoElements();
createDomains();
}

Expand All @@ -43,15 +41,9 @@ Mesh::Mesh(mfem::ParMesh&& mesh, const std::string& meshtag) : mesh_tag_(meshtag
meshtmp->EnsureNodes();
meshtmp->ExchangeFaceNbrData();
mfem_mesh_ = &smith::StateManager::setMesh(std::move(meshtmp), mesh_tag_);
errorIfRankHasNoElements();
createDomains();
}

void Mesh::errorIfRankHasNoElements() const
{
SLIC_ERROR_IF(mfem_mesh_->GetNE() == 0, "After refining and distributing mesh, local size of mesh is 0");
}

MPI_Comm Mesh::getComm() const { return mfem_mesh_->GetComm(); }

void Mesh::createDomains()
Expand Down
3 changes: 0 additions & 3 deletions src/smith/physics/mesh.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ class Mesh {
smith::FiniteElementDual newShapeDisplacementDual();

private:
/// @brief Helper function used to throw exception if the size of the mesh on the local rank is 0
void errorIfRankHasNoElements() const;

/// @brief Sets up some initial domains: entire domain, entire boundary, and interior faces. Eventually we can read
/// off names/blocks/attributes from the mesh and create default domains.
void createDomains();
Expand Down