type alias mfem::future::tuple to smith::tuple#1595
Merged
Conversation
tupek2
approved these changes
Apr 30, 2026
Collaborator
tupek2
left a comment
tupek2
left a comment
There was a problem hiding this comment.
Strategy looks good to me!
chapman39
reviewed
May 1, 2026
| * @tparam T8 The ninth type stored in the tuple | ||
| * @tparam T9 The tenth type stored in the tuple | ||
| * MFEM's tuple copy currently stores up to nine elements, while Smith's | ||
| * historical tuple API supports ten and eleven elements. |
Collaborator
There was a problem hiding this comment.
should we try to add those extra two elements to the mfem tuple implementation at some point?
chapman39
approved these changes
May 1, 2026
Collaborator
chapman39
left a comment
chapman39
left a comment
There was a problem hiding this comment.
seems like this simplifies a lot of things and reduces duplication between mfem's implementation
btalamini
approved these changes
May 3, 2026
white238
force-pushed
the
task/white238/map_mfem_tuple_to_smith_tuple
branch
from
07bece7 to
b0bf9eb
Compare
Member
Author
|
Some of these changes can be removed after we do a bulk change to mfem's tuple, after either we move the 10,11 elements to them or to the more generic tuple I'm told might come. But this is the most minimal set of changes I could come up with w/o bleeding everywhere through the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a large portion of the implementation in Smith. Originally I was going to swap completely over to the
mfem::tuplebut it exists in afuturenamespace and it would have bled over all codebase. We might want to do that when it gets out of thefuturenamespace and when we don't have large PRs up.