Don't close handle scope in GC epilogue callback #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, include.js was hard-coded to load the release build of the add-on. Now it falls back to the debug build when the release build is unavailable. Makes life easier for people who build with `node-gyp --debug rebuild` or have npm_config_debug set in the environment.
Don't call v8::HandleScope::Close() from the 'after GC' callback, there
is no parent handle scope to move the value to. Fixes the following
error in node.js debug builds:
FATAL ERROR: v8::HandleScope::CreateHandle() Cannot create a handle
without a HandleScope
|
Sorry, I should have made explicit that this bug can lead to random segmentation faults in release builds. I'll update the commit log if you want. |
bnoordhuis
added a commit
to strongloop-forks/node-memwatch
that referenced
this pull request
Jan 24, 2014
* change the package name and project URLs, we're effectively forking until lloyd#50 is resolved * add myself to the list of contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call v8::HandleScope::Close() from the 'after GC' callback, there
is no parent handle scope to move the value to. Fixes the following
error in node.js debug builds: