Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license title #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add license title #189

wants to merge 1 commit into from

Conversation

waldyrious
Copy link

It's not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)

It's not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)
@waldyrious
Copy link
Author

Pinging @octo, @tjw and @ConradIrwin, since @lloyd seems to be inactive.

@octo
Copy link
Contributor

octo commented Aug 29, 2017

Hi @waldyrious,

that sounds like a reasonable thing to add, but I have no write permissions to the yajl repo and can't approve/merge your change :(

Best regards,
—octo

@waldyrious
Copy link
Author

waldyrious commented Aug 29, 2017

Oh, I thought you did since your commits don't show up as authored by you and committed by someone else (which is the case when PRs are merged), nor they seem to have PR backreferences. In any case, thanks for the fast response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants