Alternative fix for CVE-2022-24795 #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer reallocation could cause heap corruption because of `need` overflow for large inputs. In addition, there's a possible infinite loop in case `need` reaches zero. The fix is to `abort()` if the loop ends with lower value of `need` than when it started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "hybrid" of #240, brianmario/yajl-ruby#211 and robohack/yajl@166b384
Using
abort()to avoid heap corruption/infinite loop while not adding new requirements for clients of this library and/or complex error handling mechanisms.