Skip to content

[FIRRTL] Dead port elimination on non-public module targeted by firrtl.simulation breaks verifier #10317

@fabianschuiki

Description

@fabianschuiki

If a firrtl.module is targeted by a firrtl.simulation op, IMDCE should not delete ports on the module, since those are checked by the verifier of firrtl.simulation. The workaround is to mark the module as public, but I'm not sure we'd want to enforce that. A pass modifying the IR in a way that breaks a verifier seems wrong.

Metadata

Metadata

Assignees

No one assigned

    Labels

    FIRRTLInvolving the `firrtl` dialect

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions