[CIR] Add initial support for array cookies #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We just went over a rebase against upstream, apologies for the churn but please update your branch for this PR and force-push! |
andykaylor
force-pushed
the
array-new-cookies
branch
from
8505b1e to
cee4c2f
Compare
|
The CI is failing because of the recently deprecated interfaces, so I guess this is blocked by #1299. |
This patch adds the minimal support for array cookies needed to enable ClangIR generation for an array new expression that requires cookies but does not require an explicit initializer.
andykaylor
force-pushed
the
array-new-cookies
branch
from
cee4c2f to
dc20255
Compare
|
CI is now failing in AArch64 codegen tests, still unrelated to this change. |
Rebase churn, will fix that soon! |
| // (2) The operator new call is missing "noalias noundef nonnull" on | ||
| // the call and "noundef" on the argument, (3) The getelementptr is | ||
| // missing "inbounds" |
There was a problem hiding this comment.
Nice, thanks for this! We already have issues tracking each of those, great to see no new ones!
AmrDeveloper
pushed a commit
to AmrDeveloper/clangir
that referenced
this pull request
Jan 29, 2025
This patch adds the minimal support for array cookies needed to enable ClangIR generation for an array new expression that requires cookies but does not require an explicit initializer. This only provides the cookie support for the base Itanium CXXABI. Different cookie calculations are required for AppleARM64, which will be added in a subsequent patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the minimal support for array cookies needed to enable ClangIR generation for an array new expression that requires cookies but does not require an explicit initializer.
This only provides the cookie support for the base Itanium CXXABI. Different cookie calculations are required for AppleARM64, which will be added in a subsequent patch.