Implement support for zero-initialized builtin type allocation #1304
+125
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles initialization of array new allocations in the simple case where the entire allocated memory block can be initialized with a memset to zero.
bcardosolopes
approved these changes
Feb 1, 2025
| CleanupDeactivationScope deactivation(*this); | ||
| bool pushedCleanup = false; |
There was a problem hiding this comment.
This seems unused, if you are intending to just keep track of lacking support for cleanup, using assert(!cir::MissingFeatures::requiresCleanups()); is one option.
There was a problem hiding this comment.
You're right, it is unused. The place where it would be used is covered by an "NYI" so I'll just remove it until it's needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles initialization of array new allocations in the simple case
where the entire allocated memory block can be initialized with a memset
to zero.