[CIR][CUDA] Register global variables #1978
Open
+108
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdUhTkJm
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Member
|
Good to land once the conflict is solved |
Contributor
|
@AdUhTkJm are you ok with me fixing this and adding HIP support? @bcardosolopes are you ok with having a single PR about CUDA/HIP. Or do you want these to be separate? |
Member
as long as you add tests I'm totally ok with it (it can even share the same file and just use different RUN lines) |
Contributor
Author
Yes of course. Thanks for your help! |
Contributor
|
Pushed on a separate PR (#1980). Added tests for HIP and fixed a minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process is essentially the same as registering global functions.
This currently only works for
__device__and__shared__variables. For textures and surfaces, another registration function will be needed. (We don't have support for these variables in CIR yet, and I have no idea what they really are.)