[CIR] Emit bitcast for equal-width types #1991
Merged
+160
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement VisitAsTypeExpr to lower AsTypeExpr expressions. - Emit an error when source and destination types differ in bitwidth. - When types already match, return the source value (no-op). - Otherwise lower to a CIR bitcast using cir::CastOp with CastKind::bitcast.
mahmood82
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
RiverDave
reviewed
Nov 18, 2025
Member
Please do whenever you feel like, we really appreciate it :) |
RiverDave
reviewed
Nov 20, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bcardosolopes
approved these changes
Nov 24, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Seems like there's some code formatting issues, but LGTM after that!
mahmood82
force-pushed
the
users/mahmood82/vec_reinterp
branch
from
1b96e30 to
898b7cc
Compare
Contributor
Author
Fixed.. |
Member
|
@mahmood82 after your first PR lands the testing should happen automatically, I suggest you run clang-format in your commits before pushing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for emitting a
cir.bitcastwhen reinterpretingvalues that have the same bit-width. This enables correct handling of
vector reinterpretation in CIR and aligns with the behavior of the LLVM IR
lowering.
Previously, equal-width reinterpretations were not handled, which caused
assertions or incorrect lowering when working with vector types or other
equal-sized aggregates.
Key points:
cir.bitcastemission when source and destination types haveequal width and only reinterpretation is required.
current type conversion pipeline.
Testing: