[VULKAN] Add support for specialization constants #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for specialization constants in the Vulkan backend. Key changes: - Added struct to to represent a specialization constant with its ID, type, and value. - Updated YAML mapping in to parse specialization constants from the test configuration. - Modified to create and use when creating the compute pipeline, allowing specialization constants to be passed to the shader. - Added a new test case in to verify the functionality of specialization constants with various data types (bool, int, uint, float). Fixes llvm/llvm-project#142992
Keenuts
reviewed
Nov 12, 2025
Keenuts
approved these changes
Nov 14, 2025
Contributor
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
A small improvement on an error message, otherwise LGTM
| if (!SeenConstantIDs.insert(SpecConst.ConstantID).second) | ||
| return llvm::createStringError( | ||
| std::errc::invalid_argument, | ||
| "Specialization constant ID %u is already defined", |
Contributor
There was a problem hiding this comment.
nit: would change the error to something more explicit about the location of the issue:
"YAML/config contains conflicting entries for constant ID %u"
(Looking at the test, the error could be interpreted as "we disallow constant ID reuse in the shader itself")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for specialization constants in the Vulkan backend.
Key changes:
Fixes llvm/llvm-project#142992