Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into mlir-tcp #2465

Merged
merged 52 commits into from
Sep 15, 2023

Commits on Aug 27, 2023

  1. [Torch Dialect][stablehlo] emit aten.rand op and add converter to sta…

    …blehlo (llvm#2413)
    
    * [Torch Dialect] emit aten.rand op and add converter to stablehlo
    
    * add failed tests for torchdynamo backend
    
    * add failed test for linalg backend
    Vremold committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    4339c00 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. add e2e support for aten.elu

    123epsilon authored and vivekkhandelwal1 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    12eadcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    610d836 View commit details
    Browse the repository at this point in the history
  3. update passing test sets

    123epsilon authored and vivekkhandelwal1 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5138148 View commit details
    Browse the repository at this point in the history
  4. dtype test case

    123epsilon authored and vivekkhandelwal1 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a80bc42 View commit details
    Browse the repository at this point in the history
  5. amend dtype function

    123epsilon authored and vivekkhandelwal1 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8855fa3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bc6bba9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ca34b9c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. [Importer] fix has value semantic return type (llvm#2404)

    * fix value semantic return
    
    * address comments
    
    ---------
    
    Co-authored-by: zhekun.zhang <[email protected]>
    zhekunz2 and zhekunz2 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5282324 View commit details
    Browse the repository at this point in the history
  2. [MLIR][TORCH] add E2E support for aten.min op (llvm#2422)

    * impl aten.min op
    
    * remove extraneous test
    123epsilon committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c42d2be View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Prototype passes for lowering quantized group matmul (llvm#2402)

    * Support brevitas custom op (llvm#2320)
    
    * f16 change for brevitas
    
    * Adapt the change of brevitas quant custom op name
    
    * Add unit tests
    
    * Make brevitas conversions isolated
    
    * Address the comments
    
    ---------
    
    Co-authored-by: dan <[email protected]>
    jinchen62 and dan-garvey committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    1682b54 View commit details
    Browse the repository at this point in the history
  2. [Torch Dialect] add folder for aten.any.bool (llvm#2388)

    * update
    
    * update
    
    * update
    
    * update
    
    * update
    
    * update
    
    * update
    JianzheXiao committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    17d0281 View commit details
    Browse the repository at this point in the history
  3. [LTC] Tensor[]? support operands type support using partial codegen (l…

    …lvm#2410)
    
    * Tensor[]? support operands type support using partial codegen
    
    * aten.index.Tensor support via partial codegen
    
    * Add torch.index_put tracing support
    
    * Added optional tensor list type support for LTC/TorchMLIR lowering
    
    * Added comments
    
    Co-authored-by: Gleb Kazantaev <[email protected]>
    GlebKazantaev and glebk-cerebras committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6b02e9a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. build: manually update PyTorch version

    Set PyTorch and TorchVision version to nightly release 2023-08-30.
    
    Signed-Off By: Vivek Khandelwal <[email protected]>
    vivekkhandelwal1 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    aa15f0d View commit details
    Browse the repository at this point in the history
  2. [MLIR][TORCH] Add e2e support for aten.pow.Scalar op

    Signed-Off By: Vivek Khandelwal <[email protected]>
    vivekkhandelwal1 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5c43daa View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. update PyTorch version to 2.1.0.dev20230831

     - torch version: 2.1.0.dev20230831
     - torch commit hash: b5b99fe13b890232bb61155a46239922661f4695
     - torchvision version: 0.16.0.dev20230831
    Roll PyTorch Action authored and vivekkhandelwal1 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f83ee83 View commit details
    Browse the repository at this point in the history
  2. build: manually update PyTorch version

    Set PyTorch and TorchVision version to nightly release 2023-09-01.
    
    Signed-Off By: Vivek Khandelwal <[email protected]>
    vivekkhandelwal1 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    729386c View commit details
    Browse the repository at this point in the history
  3. [MLIR][TORCH] add E2E support for aten.rand (llvm#2424)

    * impl decomposition for aten.rand
    
    * remove stablehlo conversion for aten.rand
    123epsilon committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    34a0897 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1fc4314 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. [MLIR][TORCH] Add E2E support for view_as_real op (llvm#2419)

    * view_as_real test case, allow dtype in testutils.randn
    
    * abstract python upstream func implemented
    
    * fixed upstream dtype func, implemented view_as_real backend op
    
    * formatted AtenViewAsRealOp, removed change in e2etest/framework
    
    * removed test suit from reshape_like.py, because it's moved to basic.py
    
    * implemented C-API wrapper for mlirComplexF128 type
    
    * fixed torch.complex dtype width in MLIR and Torch MLIR, deleted float16 dtype dict
    
    * Changed IR input of aten fft_fft unit test
    
    * code refactored
    
    * code refactored and fixed ci test
    
    * refactored: removed white spaces, and rolled back to having both input/output affine expr
    
    * refactored: deleted output affine expr to reduce redundancy
    
    * xfail ltc backend
    
    * removed ComplexImag and ComplexReal from torchdynamo xfail set
    
    * copied and pasted from main branch as there's no change to be made in this file
    
    * refactored abstract_interp_lib_gen.py
    
    * refactored: torchtypes.td, formatted, removed commented out code
    brucekimrokcmu committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    cd1c7df View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. [Torch Dialect] support aten.split_with_sizes (llvm#2431)

    * [Torch Dialect] support aten.split_with_sizes
    
    * update
    qingyunqu committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    e9ab8ce View commit details
    Browse the repository at this point in the history
  2. [stablehlo] add AtenScalarImplicitOp's reverter to stablehlo backend (l…

    …lvm#2434)
    
    * add ScalarImplicitOp's reverter to stablehlo backend
    
    * add new passed test case for stablehlo backend
    Vremold committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    30510f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a3ac451 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Configuration menu
    Copy the full SHA
    d62045f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3841fe3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c93c697 View commit details
    Browse the repository at this point in the history
  4. [MLIR][TORCH] Add E2E torch.aten.prod_dim_int (llvm#2423)

    Uses the existing reduction codepath, adding modifications or branches
    required alongside for prod.
    jerinphilip committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9cb5d38 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Fix GCC warning recommending parens.

    Found with a more strict set of warning flags on GCC 9.
    stellaraccident committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    29fdc38 View commit details
    Browse the repository at this point in the history
  2. Properly guard clang-specific pragma.

    Avoids unsupported pragma warning on GCC.
    stellaraccident committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    fcb3b71 View commit details
    Browse the repository at this point in the history
  3. [Torch Dialect] emit aten.__or__Tensor Op (llvm#2437)

    * emit aten.__or__TensorOp
    
    * bug fix
    
    * remove convert to stablehlo
    
    * code style refinement
    Vremold committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b411a40 View commit details
    Browse the repository at this point in the history
  4. build: manually update PyTorch version

    Set PyTorch and TorchVision version to nightly release 2023-09-06.
    
    Signed-Off By: Vivek Khandelwal <[email protected]>
    vivekkhandelwal1 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    67ae97f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    a8fd275 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27b55b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Configuration menu
    Copy the full SHA
    cfd70df View commit details
    Browse the repository at this point in the history
  2. update PyTorch version to 2.2.0.dev20230908 (llvm#2433)

    - torch version: 2.2.0.dev20230908
     - torch commit hash: 806d1a871ddfd2d38e1791489892009feaec8425
     - torchvision version: 0.17.0.dev20230908
    
    Co-authored-by: Roll PyTorch Action <[email protected]>
    stellaraccident and Roll PyTorch Action committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4dac1a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. update PyTorch version to 2.2.0.dev20230909 (llvm#2450)

    - torch version: 2.2.0.dev20230909
     - torch commit hash: 11d2c766f14dae98296056ee16827ffbd6a4d509
     - torchvision version: 0.17.0.dev20230909
    
    Co-authored-by: Roll PyTorch Action <[email protected]>
    stellaraccident and Roll PyTorch Action committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    cc4a5d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    1f20b72 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    5895b9f View commit details
    Browse the repository at this point in the history
  2. build: manually update PyTorch version

    Set PyTorch and TorchVision version to nightly release 2023-09-11.
    
    Signed-Off By: Vivek Khandelwal <[email protected]>
    vivekkhandelwal1 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c1f379f View commit details
    Browse the repository at this point in the history
  3. [MLIR][TORCH] Add different dtype support for aten.bmm op

    Signed-Off By: Vivek Khandelwal <[email protected]>
    vivekkhandelwal1 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    23b7224 View commit details
    Browse the repository at this point in the history
  4. [MLIR][TORCH] add E2E support for aten.new_full (llvm#2425)

    * implement aten.new_full
    
    * remove extraneous tests
    123epsilon committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    82456ee View commit details
    Browse the repository at this point in the history
  5. [MLIR][TORCH] Add E2E support for aten.empty_strided decomposition op (

    …llvm#2457)
    
    * implemented e2e test case, shape, dtype func
    
    * AtenEmptyStrided decompose op implemented
    
    * xfailed test module in ltc
    brucekimrokcmu committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    97bec86 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    106b585 View commit details
    Browse the repository at this point in the history
  7. Integrate llvm-project and mlir-hlo. (llvm#2454)

    Corresponding commits:
    
    * mlir-hlo: 16886a108eff5197f816ca0f1950cc5ff1b078d9
    * stablehlo: 77a59815a82b34f7b08ed2d42a711d9920682d0e
    * llvm-project: 4acc3ffbb0af5631bc7916aeff3570f448899647
    
    * Adapt to ByteCodeOpInterface changes.
    * Adapt to RegionBranchPoint changes: https://reviews.llvm.org/D159116
    * Adapt inferReturnTypes to get the value from properties.
    * Adapt invalid.mlir to properties syntax
    * [TOSA] Align with custom assembly format change.
    * [TOSA] handle change of axis to int32 type
    * [TOSA] Restore improper convert to i32
    
    Landing with Windows broken (it cannot be fixed because of the way the mlir-hlo dep is inserted). Will followup with an untangling.
    ---------
    
    Co-authored-by: TatWai Chong <[email protected]>
    Co-authored-by: Eric Kunze <[email protected]>
    3 people committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a00a0d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Remove mlir-hlo (replace with stablehlo). (llvm#2460)

    We just have to do this: I ran into an issue today where I needed to make a one line patch to stablehlo to work around a compiler issue, and it is completely unapparent how to do so given that the mlir-hlo repo is a read-only export and is at the tail end of a multi-week integration chain from the open-source stablehlo repo.
    
    We've discussed this often enough and gotten +1 from everyone that they are ok with taking the e2e testing hit if it becomes necessary: It is necessary as the current situation is unmanageable.
    
    Looking at it, I expect it wouldn't actually be very difficult to build a little runner binary out of the stablehlo interpreter and subprocess call that in order to get the testing coverage back. I leave that as an exercise to the users of this part of the stack and recommend following the breadcrumbs from the deleted python/torch_mlir_e2e_test/stablehlo_backends/linalg_on_tensors.py file and the main.py changes.
    
    Note that I am pointing us at a stablehlo fork for the moment until it is apparent that we don't need to carry any local patches to it. We can update this in a few days if everything is clear.
    stellaraccident committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    078d1e1 View commit details
    Browse the repository at this point in the history
  2. Fix two CMake issues that were causing Windows compilation failures. (l…

    …lvm#2461)
    
    At some point in the past month, stablehlo gained a number of patches that implement a non-trivial bit of threaded reference code. It fails to compile in Windows in pretty catastrophic ways.
    
    But this isn't the main problem: by way of the MLIR CMake macros being used, if we include stablehlo before our code, we end up building the whole project, whether needed or not.
    stellaraccident committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    107ed0d View commit details
    Browse the repository at this point in the history
  3. build: manually update PyTorch version

    Set PyTorch and TorchVision version to nightly release 2023-09-13.
    Ref: pytorch/pytorch@464f9c3
    
    Signed-Off By: Vivek Khandelwal <[email protected]>
    vivekkhandelwal1 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    4b4c38d View commit details
    Browse the repository at this point in the history
  4. [MLIR][TORCH] Add E2E support for aten.empty_strided decomposition op…

    … (redo PR) (llvm#2459)
    
    Making the same PR with llvm#2457, as I accidentally thought the review was already made and merged it (reverted).
    
    Add decompose empty_strided op.
    Referring to llvm#1776, this decomposition op only supports default stride values, because accessing the tensor or indexing over that, the indices are determined by the strides.
    In MLIR, this is not implicitly supported but assumes that the strides are default while iterating over the tensor.
    brucekimrokcmu committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    40913a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    3d974ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd32a09 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    158ec7d View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. We don't support complex types in tcp.mul today. Without this, it fai…

    …ls the TCP e2e integration test for ElementwiseMulTensorComplexModule_basic...
    sjain-stanford committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    4d90ab4 View commit details
    Browse the repository at this point in the history