[Tcp] Handle int inputs in sqrt #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SameOperandsAndResultShape, | ||
| SameOperandsAndResultElementType])> { | ||
| SameOperandsAndResultShape])> { |
There was a problem hiding this comment.
Since all elementwise ops except tcp.sqrt adhere to the SameOperandsAndResultElementType trait, is it better to leave this as-is, and let Tcp_SqrtOp just be a Tcp_Op that uses a relaxed set of traits?
There was a problem hiding this comment.
It is still useful to be able to identify all the unary elementwise ops using the common base class type.
If there are more such ops in future, we could add another base type that can be common to all of them.
sjain-stanford
approved these changes
Sep 16, 2023
I wanted to do that as a separate PR. Will do as a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for integer inputs in
tcp.sqrt.