Skip to content

Conversation

mingzheTerapines
Copy link
Contributor

Co-authored by: [email protected]

Improve usage of static shape information to avoid unnecessary broadcast.

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR!

Let me know if you have trouble finding an existing utility function, since it would be better to re-use existing util functions rather than filling the current file with one-off functions.

I'd also prefer if we added a lit test to cover this change.

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of the useless dynamic broadcast is great, thanks. When you clean up the lit test a bit, I'll stamp and merge.

@mingzheTerapines mingzheTerapines force-pushed the fix/multi-batch-matmul-to-linalg branch 2 times, most recently from ede1ec9 to ec5ca99 Compare October 10, 2025 01:45
@zjgarvey zjgarvey enabled auto-merge (squash) October 10, 2025 03:36
@zjgarvey zjgarvey merged commit 18e6b7f into llvm:main Oct 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants