fix: remove split.Tensor and split_with_sizes from decomp tables #4340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may need to add the recompose pass to the very beginning of |
|
Hey, can you open a separate PR for the pytorch cxx abi changes? They look great, but make that a standalone patch. We can sync this branch with main when done. |
Sure, I don't even know if they work though. I can't reproduce locally. |
raayandhar
force-pushed
the
remove_split
branch
from
31889f9 to
55c7704
Compare
Signed-off-by: raayandhar <[email protected]>
Signed-off-by: raayandhar <[email protected]>
Signed-off-by: raayandhar <[email protected]>
raayandhar
force-pushed
the
remove_split
branch
from
55c7704 to
09bd759
Compare
|
@zjgarvey re-requesting a review now that I'm back on this-thanks for your help fixing CI! |
|
I still think we should also merge #4334, since we will not be deprecating as_strided just yet |
zjgarvey
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details are in the issue: #4339
Since
split.Tensorandsplit_with_sizesdecompose toas_strided(see issue above whyas_stridedis problematic), we remove them from the decomp tables.cc @zjgarvey