[TOSA] Conv3d legalization #4383
Merged
+887
−407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catcor01
force-pushed
the
conv3d
branch
2 times, most recently
from
4042fcd to
d7fa53c
Compare
Collaborator
Lallapallooza
left a comment
Lallapallooza
left a comment
There was a problem hiding this comment.
Thanks for PR, overall LGTM, few nits.
sahas3
reviewed
Dec 1, 2025
Member
sahas3
left a comment
sahas3
left a comment
There was a problem hiding this comment.
Thanks for this substantial contribution.
sahas3
reviewed
Dec 1, 2025
sahas3
approved these changes
Dec 2, 2025
Member
sahas3
left a comment
sahas3
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback so quickly. It'll be great if you address the bias computation feedback. The rest are mainly nits.
catcor01
force-pushed
the
conv3d
branch
2 times, most recently
from
2c0d4a2 to
25200e9
Compare
- Extend Torch to TOSA conversion with full aten.conv3d coverage, mapping padding/stride/dilation configs and bias handling into canonical TOSA conv ops. - Refactor TorchToTosa lowering utilities to share more code between conv variants. - Update conversion tests plus PT1 xfail lists to reflect the newly supported 3D convolution paths. Signed-off-by: Cathal Corbett <[email protected]> Change-Id: Iaf1261e121dec1ddb84b814e9058bb7ebadd4de7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Iaf1261e121dec1ddb84b814e9058bb7ebadd4de7