Display hourly icons above temperature line #136
+190
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates pointers to 32 pc bitmaps which are then drawn at the x-axis tick marks except for the first and last one and the above the temperature line. Tested with different HOURLY_GRAPH_MAX. Still readable if precipitation overlaps, however a grayscale option would be truly amazing for this (is this feasible?). Currently does not differentiate between moon present or absent, night time is always with moon. Only tested with DISP_BW_V2, therefore only enabled for this display.
The temperature line is shifted by half an hour I think. Maybe there is a good reason for this that I missed. This change aligns the line correctly and adds one more index for the last hour. However, it limits the number of hours to 47.
For some reason, for me it would always refresh 1 minute before the full or half hour. This bugged me, also because of the corresponding x-axis limits. This might just be a problem on my end though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Luke,
love the project! Will be a christmas present ;)
I've added hourly weather icons above the temperature line in order to visualize the weather throughout the day in more detail. See commit message for more info.
I've also made two additional minor commits. They are not necessary for the hourly weather icons and might just be a misunderstanding on my end.
I've tested my changes briefly with slightly varying configs but it is definitely possible that there are display problems in edge cases, for example very strong temperature gradient. Also this is my first time working with C++, so hopefully no bugs.
Merry Christmas,
Dominic