Fixing flaky failures in test_umap_metrics.py
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried running your tests by removing the seed setting lines (such as
np.random_seed(SEED)inumap/tests/conftests.py. I observed that testtest_grad_metrics_match_metricsintest_umap_metrics.pyfails 25/500 times that I ran. Each time the assertion for themahalanobismetric failed.Changing the default
decimalplaces from6to5makes sure that the test does not fail (without seeds). Please let me know if this change seems reasonable. If yes, then I can look into some other tests which also failed during this experiment.If you have any other suggestions, I will be happy to look into it and/or include it in this PR. Please let me know if you need any other info.
Thanks!