-
Notifications
You must be signed in to change notification settings - Fork 150
build(deps): bump prost from 0.13.5 to 0.14.1 in /app-server #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 0262fdd in 3 minutes and 55 seconds. Click for details.
- Reviewed
91lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. app-server/Cargo.toml:35
- Draft comment:
Bump of prost to 0.14 is present, but note that build dependencies (tonic-build) seem to pull in prost-build (and hence prost-types) at version 0.13.5. This creates two different prost versions in the dependency graph, which could lead to type or compatibility issues. Verify that all crates using prost (including those indirectly via tonic-build) are compatible with 0.14, or consider updating tonic-build if available. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a dependency-related comment that speculates about potential compatibility issues. The rules explicitly state not to comment on dependency changes or versions. Additionally, Rust's package manager Cargo would likely catch any actual incompatibility issues during build time. The comment is asking for verification rather than pointing out a definite issue. The comment might be identifying a real technical concern about version mismatches that could cause subtle runtime issues. Version conflicts in protobuf-related libraries can sometimes slip through compilation. While the concern might be valid, it falls under multiple exclusion rules: don't comment on dependencies, don't make speculative comments, and don't ask for verification. Any real incompatibility would be caught by Cargo or tests. Delete this comment as it violates multiple review rules: it's about dependencies, it's speculative, and it asks for verification rather than pointing out a definite issue.
2. app-server/Cargo.toml:2
- Draft comment:
Project edition is set to "2024"; ensure that your toolchain supports this edition (it might require using a nightly compiler) and that all contributors are aligned on the required Rust version. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. app-server/Cargo.lock:3785
- Draft comment:
Typographical issue: The dependency string "prost 0.13.5" seems off. Given the commit title indicates a bump from 0.13.5 to 0.14.1, this line likely should either remain as "prost" (with the version managed elsewhere), or if inlining the version, update it to "prost 0.14.1". - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% Cargo.lock files are automatically generated and managed by Cargo. The apparent inconsistency is likely intentional - different dependencies may require different versions of prost, and Cargo resolves these requirements automatically. The comment suggests manual editing of Cargo.lock, which is not recommended practice. The comment raises a valid observation about version inconsistency. Could this inconsistency cause problems at runtime? No - Cargo's dependency resolution is specifically designed to handle multiple versions of the same package safely. The Cargo.lock file should not be manually edited to force version alignment. The comment should be deleted because it suggests manually modifying the Cargo.lock file, which is an anti-pattern. The version differences are handled automatically by Cargo's dependency resolution.
Workflow ID: wflow_uwU46G8QbCGOvKBe
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Bumps [prost](https://github.com/tokio-rs/prost) from 0.13.5 to 0.14.1. - [Release notes](https://github.com/tokio-rs/prost/releases) - [Changelog](https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md) - [Commits](tokio-rs/prost@v0.13.5...v0.14.1) --- updated-dependencies: - dependency-name: prost dependency-version: 0.14.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
0262fdd to
89f5c5b
Compare
Bumps prost from 0.13.5 to 0.14.1.
Changelog
Sourced from prost's changelog.
... (truncated)
Commits
9965a98chore: Release version 0.14.1 (#1299)0caca29Revert "feat(prost-build): emitreruncommands (#1140)" (#1297)3543eb8chore: Release version 0.14.0 (#1276)1e93f56build(deps): update criterion requirement from 0.5 to 0.6 (#1280)bdd03fcUpdate config.rs (#1270)fcf610eci: Run clippy with edition 2024 enabled (#1256)8a3d42edocs: update dead link LICENSE inprost-types/README.md(#1262)97d5841chore: fix typo (#1260)5c97cf8build(deps): Update pulldown-cmark to 0.13 (#1259)db871b4hardenref mutaccording to edition 2024 (#1248)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Important
Bump
prostfrom 0.13.5 to 0.14.1 inapp-server, updating dependencies and handling breaking changes.prostfrom 0.13.5 to 0.14.1 inCargo.tomlandCargo.lock.prost-deriveto 0.14.1 inCargo.lock.prostno longer requiresDebugtrait forMessagetrait.prost-derivefeature toderive.prost-buildno longer boxes repeated fields.type_name_domainconfiguration is now cumulative.prost-buildderivesEqandHashwhere possible.reruncommands inprost-build.This description was created by
for 0262fdd. You can customize this summary. It will automatically update as commits are pushed.