Skip to content

Add support for Muse Glimmer and its tool format - #364

Merged
neilmehta24 merged 5 commits into
mainfrom
neil/muse-glimmer-mlx
Aug 17, 2026
Merged

Add support for Muse Glimmer and its tool format#364
neilmehta24 merged 5 commits into
mainfrom
neil/muse-glimmer-mlx

Conversation

@neilmehta24

Copy link
Copy Markdown
Member
  • Update mlx-vlm pin to add support for Muse Glimmer
  • Add support for glimmer's tool calling grammar, in order to constrain invalid logits during tool call generation
  • Update the batch generator to eval the prefill arrays before moving on to decode, in order to fix the prefill/decode latency attribution. Previously, the final prefill work was being tracked as the first decode token latency, which misattributes the latency profiles. E2E request completion time is unaffected.

Performance on M2 Mac Studio:

  • Decode: 31.5 tok/s at low context; 29 tok/s at 8k context length
  • Prefill: 175 tok/s for 8k context

@github-actions github-actions Bot added the CLA signed Indicates that all contributors have signed label Aug 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3cdc582c1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread mlx_engine/tool_runtime.py
@neilmehta24
neilmehta24 force-pushed the neil/muse-glimmer-mlx branch from 6911752 to d3cdc58 Compare August 12, 2026 16:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 691175209d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread mlx_engine/tool_runtime.py
@neilmehta24
neilmehta24 merged commit 39b8521 into main Aug 17, 2026
4 checks passed
@neilmehta24
neilmehta24 deleted the neil/muse-glimmer-mlx branch August 17, 2026 16:27
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA signed Indicates that all contributors have signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants