Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "routes", use route hints on invoice instead #25

Closed
wants to merge 1 commit into from
Closed

remove "routes", use route hints on invoice instead #25

wants to merge 1 commit into from

Conversation

fiatjaf
Copy link
Collaborator

@fiatjaf fiatjaf commented Nov 23, 2019

So given that LN WALLET sent fromnodes=dd8d3d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187 LN SERVICE would return an invoice with many full routes like this:

{
  "currency": "bc",
  "created_at": 1574450520,
  "expiry": 36000,
  "payee": "02bed1812d3824f7cc4ccd38da5d66a29fcfec146fe95e26cd2e0d3f930d653a8d",
  "msatoshi": 2500,
  "amount_msat": "2500msat",
  "min_final_cltv_expiry": 10,
  "features": "",
  "routes": [
    [
      [
        {
          "pubkey": "dd8d3d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187",
          "short_channel_id": "596242x2207x0",
          "fee_base_msat": 1000,
          "fee_proportional_millionths": 1,
          "cltv_expiry_delta": 40
        }
      ],
      [
        {
          "pubkey": "6fd53d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187",
          "short_channel_id": "601223x2207x0",
          "fee_base_msat": 1000,
          "fee_proportional_millionths": 1,
          "cltv_expiry_delta": 40
        }
      ],
      [
        {
          "pubkey": "40483d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187",
          "short_channel_id": "568245x2207x0",
          "fee_base_msat": 1000,
          "fee_proportional_millionths": 1,
          "cltv_expiry_delta": 40
        }
      ]
    ],
    [
      [
        {
          "pubkey": "dd8d3d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187",
          "short_channel_id": "522145x2207x0",
          "fee_base_msat": 1000,
          "fee_proportional_millionths": 1,
          "cltv_expiry_delta": 40
        }
      ],
      [
        {
          "pubkey": "7f103d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187",
          "short_channel_id": "600000x2207x0",
          "fee_base_msat": 1000,
          "fee_proportional_millionths": 1,
          "cltv_expiry_delta": 40
        }
      ],
      [
        {
          "pubkey": "92923d84886059292845f870c5229f103dd8d7d71d7e9fc6fd52f75a40486d2187",
          "short_channel_id": "593545x2207x0",
          "fee_base_msat": 1000,
          "fee_proportional_millionths": 1,
          "cltv_expiry_delta": 40
        }
      ]
    ]
  ],
  "payment_hash": "13c034cb0aed72c0a2ee54c5678bd13b0bf64017fddd3dd6825205df4c17c6e0",
  "signature": "3044022069e467ff258325c25f59ba7448e466441bb30fe6040f03fc77181672f106ca780220617525cbee5ebb5b9f5ee8f87a8b66c2ddae2ab063b1999b0747ab3df862242e"
}

And every wallet already knows how to parse and handle this (or they should at least).

@fiatjaf
Copy link
Collaborator Author

fiatjaf commented Mar 14, 2020

Now that this is being considered this proposal is making even more sense.

@fiatjaf
Copy link
Collaborator Author

fiatjaf commented Apr 7, 2020

The blinded stuff is making its moves towards BOLT: lightning/bolts#765

@hsjoberg hsjoberg closed this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants