Skip to content

Mergin weather-qt and weather-cmd into one project#13

Open
hef wants to merge 2 commits intoloansindi:masterfrom
hef:master
Open

Mergin weather-qt and weather-cmd into one project#13
hef wants to merge 2 commits intoloansindi:masterfrom
hef:master

Conversation

@hef
Copy link
Copy Markdown

@hef hef commented May 23, 2018

I'm wondering if you thing this would be a good idea:

The idea is to first move weather-qt and weather-cmd into a common codebase, and then move the common functionality into a common space for both programs

@loansindi
Copy link
Copy Markdown
Owner

in principle, it shouldn't be that hard to kludge these two together. There's no good reason there couldn't be a command line flag --no-gui or something similar. It's been kicking around in the back of my head. I don't know what timeline makes the most sense for merging stuff together, whether it would be better to rip off the bandaid or wait a bit. I'm open to feedback.

@hef
Copy link
Copy Markdown
Author

hef commented May 23, 2018

This actually keeps the 2 projects separate, but allows for code sharing between them.

I added a patch that seperates getReport() from the cmd version into a "weather-lib" , and refactors both weather-qt and weather-cmd to call getReport() from weather-lib

@hef
Copy link
Copy Markdown
Author

hef commented May 23, 2018

QT Creator lets you switch between the 2 programs

screen shot 2018-05-23 at 10 01 08 am

@loansindi
Copy link
Copy Markdown
Owner

@jobybenoit do you wanna try out this PR and make sure both apps seems to function (though I expect weather-cmd will still crash at printing, i haven't investigated that yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants