Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: display issue when select default model in System Agent #3095

Merged
merged 6 commits into from
Jul 1, 2024
Merged

🐛 fix: display issue when select default model in System Agent #3095

merged 6 commits into from
Jul 1, 2024

Conversation

hezhijie0327
Copy link
Contributor

@hezhijie0327 hezhijie0327 commented Jun 30, 2024 •
edited by arvinxx
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

修复 #2982 中，选中默认 Model 后，无法正常显示的问题

close #2982

📝 补充信息 | Additional Information

Before
image
After
image

@vercel Vercel
Copy link

vercel bot commented Jun 30, 2024

@hezhijie0327 is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @hezhijie0327

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@codecov Codecov
Copy link

codecov bot commented Jun 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.82%. Comparing base (a148c3b) to head (1fd321a).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
+ Coverage   93.43%   93.82%   +0.39%     
==========================================
  Files         382      388       +6     
  Lines       23629    23943     +314     
  Branches     1717     1767      +50     
==========================================
+ Hits        22077    22465     +388     
+ Misses       1552     1478      -74
Flag Coverage Δ
app 93.82% <ø> (+0.39%) ⬆️
server 68.17% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arvinxx
arvinxx reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照你现在的改造，我们是不是可以抽一个通用组件出来? 这样 props 就只用配置一个 systemAgentKey 就好了

src/app/(main)/settings/system-agent/features/Topic.tsx Outdated Show resolved Hide resolved
@hezhijie0327
Copy link
Contributor Author

按照你现在的改造，我们是不是可以抽一个通用组件出来? 这样 props 就只用配置一个 systemAgentKey 就好了

已实现

<SystemAgentForm systemAgentKey="topic" />
<SystemAgentForm systemAgentKey="translation" />
<SystemAgentForm systemAgentKey="agentMeta" />

arvinxx
arvinxx approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

优雅~

@arvinxx arvinxx changed the title 🐛 fix: display issue when select default model in System Agent #2982 🐛 fix: display issue when select default model in System Agent Jul 1, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 4:13pm

@arvinxx arvinxx merged commit 49f7f33 into lobehub:main Jul 1, 2024
6 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @hezhijie0327 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 1, 2024
@semantic-release-bot
🔖 chore(release): v1.2.2 [skip ci]
d71108a 
### [Version&nbsp;1.2.2](v1.2.1...v1.2.2)
<sup>Released on **2024-07-01**</sup>

#### 🐛 Bug Fixes

- **misc**: Display issue when select default model in System Agent.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Display issue when select default model in System Agent, closes [#3095](#3095) ([49f7f33](49f7f33))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 1, 2024
@semantic-release-bot
🔖 chore(release): v1.45.1 [skip ci]
cb930d5 
### [Version&nbsp;1.45.1](v1.45.0...v1.45.1)
<sup>Released on **2024-07-01**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor the portal file, refactor the portal implement.

#### 🐛 Bug Fixes

- **misc**: Display issue when select default model in System Agent.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor the portal file, closes [lobehub#3106](https://github.com/bentwnghk/lobe-chat/issues/3106) ([2d9635f](2d9635f))
* **misc**: Refactor the portal implement, closes [lobehub#3110](https://github.com/bentwnghk/lobe-chat/issues/3110) ([53fb292](53fb292))

#### What's fixed

* **misc**: Display issue when select default model in System Agent, closes [lobehub#3095](https://github.com/bentwnghk/lobe-chat/issues/3095) ([49f7f33](49f7f33))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@hezhijie0327 hezhijie0327 deleted the sysagent branch July 2, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx arvinxx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] 消息内容选gpt3.5的时候显示不出来。
3 participants
@hezhijie0327 @lobehubbot @arvinxx