-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to backstage v1.6.0 & remove unnecessary react-router dep #190
Add support to backstage v1.6.0 & remove unnecessary react-router dep #190
Conversation
Signed-off-by: ivgo <[email protected]>
@satrox28 this is very important for any adopter to perform: https://backstage.io/docs/tutorials/react-router-stable-migration if they are using GitLab Plugin. |
Any news on this? We have the same issue and i would like to update to the current backstage version. |
@richardmcsong please take a look. |
Hi. Any update on this? We would really like to get rid of the beta version of react router and update to the latest version of backstage (1.7.0 already) |
Let me bump this, as I started playing around with backstage starting with 1.6.0, this plugin never worked for me. Does Loblaw plan to maintain the plugin, or should the community start thinking about a fork? |
@satrox28 Would you mind help looking into this issue? |
Can anyone approve this please? It is blocking gitlab's integration in backstage's newest release. |
As a workaround, I created a mimic lib tested with backstage v1.8.0. You can use this lib while waiting for the official one to be updated. |
Hi All, I am no longer with the Organization, have informed the required folks, please allow sometime for them to respond here. |
|
Is it possible to get this PR reviewed and merged so latest package is published and can be consumed in Backstage 1.6.0+? |
Hi guys! |
Added support to the latest version of backstage.
This change is really important, and many people might face issues upgrading their plugin in the near future.
Also, I removed the
react-router
dependency and, consequently, a few lines in theRouter.ts
file, as this is not needed to display theGitlabCi
component.