-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document available eks versions #1597
Conversation
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1597.surge.sh 🎊 |
Below is the list of supported Kubernetes versions and their corresponding k3s versions. | ||
The default version is `1.22`. | ||
|
||
| Kubernetes Version | k3s Version | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this list of supported versions comes from the source code? My concern is keeping this list up to date with the supported versions.
We are already 2 releases behind the current release in both the source code and this table. Is there any way we can keep these two up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I added a script which is able to automatically keep the available versions up to date in our codebase, that can also be used to keep this table up to date. I am however a bit reluctant to add this functionality, as it might be superseded soon. I think we can do another manual update, and automate this in the future!
Below is the list of supported Kubernetes versions and their corresponding k3s versions. | ||
The default version is `1.22`. | ||
|
||
| Kubernetes Version | k3s Version | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I added a script which is able to automatically keep the available versions up to date in our codebase, that can also be used to keep this table up to date. I am however a bit reluctant to add this functionality, as it might be superseded soon. I think we can do another manual update, and automate this in the future!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two suggested changes to make it clearer what image we are starting - good to merge from my side afterwards.
Co-authored-by: Daniel Fangl <[email protected]>
No description provided.