Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document available eks versions #1597

Merged
merged 3 commits into from
Feb 24, 2025
Merged

document available eks versions #1597

merged 3 commits into from
Feb 24, 2025

Conversation

HarshCasper
Copy link
Member

No description provided.

@HarshCasper HarshCasper requested a review from dfangl as a code owner December 15, 2024 08:36
Copy link

github-actions bot commented Dec 15, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1597.surge.sh 🎊

@HarshCasper HarshCasper requested a review from simonrw December 16, 2024 13:45
Below is the list of supported Kubernetes versions and their corresponding k3s versions.
The default version is `1.22`.

| Kubernetes Version | k3s Version |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this list of supported versions comes from the source code? My concern is keeping this list up to date with the supported versions.

We are already 2 releases behind the current release in both the source code and this table. Is there any way we can keep these two up to date?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I added a script which is able to automatically keep the available versions up to date in our codebase, that can also be used to keep this table up to date. I am however a bit reluctant to add this functionality, as it might be superseded soon. I think we can do another manual update, and automate this in the future!

@HarshCasper HarshCasper marked this pull request as draft January 2, 2025 13:23
Below is the list of supported Kubernetes versions and their corresponding k3s versions.
The default version is `1.22`.

| Kubernetes Version | k3s Version |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I added a script which is able to automatically keep the available versions up to date in our codebase, that can also be used to keep this table up to date. I am however a bit reluctant to add this functionality, as it might be superseded soon. I think we can do another manual update, and automate this in the future!

@HarshCasper HarshCasper marked this pull request as ready for review February 24, 2025 10:02
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two suggested changes to make it clearer what image we are starting - good to merge from my side afterwards.

@HarshCasper HarshCasper merged commit 8bb50de into main Feb 24, 2025
5 checks passed
@HarshCasper HarshCasper deleted the eks-version branch February 24, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants