Remove obsolete version top-level elements from compose examples #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files, include default docker compose files from github directly
dfangl
requested review from
silv-io,
simonrw,
dominikschubert,
pinzon and
joe4dev
as code owners
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1687.surge.sh 🎊 |
dfangl
requested review from
HarshCasper
and removed request for
simonrw,
dominikschubert,
joe4dev,
silv-io,
pinzon and
bentsku
|
Note that the preview still shows the version tag in the github-pulled files - I merged the PR after the build already started. |
alexrashed
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
praise: Nice! This way they will be updated on every build! 🤩
HarshCasper
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reason for removing the version attributes see localstack/localstack#12354.
Also, hugo now takes the default docker compose files directly from the localstack/localstack repository using the github shortcode.
For this to work, I needed to enable the github shortcode to include the file as-is, without any highlighting, as the highlights are already done in the tab.
Happy to discuss this, if there is a better solution.
Changes
versiontop level attributes from all docker compose examples.