Add support for providing env vars with envFrom #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We include the localstack helm chart as a dependency to a wrapper chart and would like to be able to set an environment variable that is derived from a value passed to the wrapper. This is currently not possible as the values for the localstack subchart can not refer to another value. Here's a brief example of how we'd like to use this:
Chart.yaml:
Wrapper chart values.yaml
localstack-env-vars-configmap.yaml
Changes
The PR adds support for providing environment variables via ConfigMaps and/or Secrets via envFrom.