Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQS endpoint to cert domains #20

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add SQS endpoint to cert domains #20

merged 1 commit into from
Nov 6, 2023

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Oct 24, 2023

This PR adds the URL scheme introduced by the new SQS standard endpoint strategy, to the cert FQDN.

@viren-nadkarni viren-nadkarni changed the title Update cert domains Add SQS endpoint to cert domains Oct 25, 2023
@viren-nadkarni viren-nadkarni requested review from alexrashed, whummer and dfangl and removed request for alexrashed October 25, 2023 07:40
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will defer to @dfangl for final sign-off, but LGTM! Great to see this CI action being extended for additional service use cases 🚀

Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dfangl dfangl merged commit 34b3780 into master Nov 6, 2023
1 check passed
@dfangl dfangl deleted the update-endpoints branch November 6, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants