Azure: Add ACR to certificate-domains #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New entry for the certificate domains to use this mechanicsm for Azure Container Registry (ACR).
Note that there is no rush behind this - the current implementation just has some limitations that we need to address at some point, and that needs an HTTPS domain name.
On the naming:
The original URL is
{registry_name}.azurecr.io, so keeping theazurecrin the host is for users an easy way to identify what this URL is about.I've considered using a generic prefix to separate this domain from the AWS ones, like
acr.azure.localhost.localstack.cloud, but the termACRis already unique to Azure - so addingazureagain does not add any new information IMO.