Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for built-in Esbuild in Serverless Framework v4 #267

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

czubocha
Copy link
Contributor

Serverless Framework v4 introduced a built-in (internal) Esbuild plugin, so there's no need to use an external one. This PR adds support for it. Since this plugin is always loaded, the static function WillEsBuildRun is used to determine if it is actually in use.

@pinzon pinzon self-requested a review October 30, 2024 16:39
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks to the Serverless team for enhancing the plugin directly!

@pinzon pinzon merged commit 62b9d5e into localstack:master Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants