Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to skip overrides by provider alias #60

Merged
merged 2 commits into from
Aug 9, 2024
Merged

allow to skip overrides by provider alias #60

merged 2 commits into from
Aug 9, 2024

Conversation

Hoffs
Copy link
Contributor

@Hoffs Hoffs commented Aug 8, 2024

This PR adds ability to not generate overrides for AWS providers by specific aliases. The justification for this feature is that it allows to use real AWS resources for certain resources by utilizing provider aliases and localstack for others.

Copy link
Contributor

@lakkeger lakkeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, kudos to tackle it 💯 🎉

@lakkeger
Copy link
Contributor

lakkeger commented Aug 9, 2024

Small nit, could you please bump the feature version and update the docs according to the changes before I merge it?

@Hoffs
Copy link
Contributor Author

Hoffs commented Aug 9, 2024

sure, updated, unless I missed something

@lakkeger lakkeger merged commit 62b5cc1 into localstack:main Aug 9, 2024
3 checks passed
@Hoffs Hoffs deleted the feat/ignore-aliases branch August 9, 2024 07:52
@lakkeger
Copy link
Contributor

lakkeger commented Aug 9, 2024

This version is available now on pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants