Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoTiffReader Unknown tags skip fix #3557

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Jan 4, 2025

Overview

This PR fixes the GeoTiffReader implementing a proper unknown TiffTags skip logic.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • Unit tests added for bug-fix or new feature

Closes #3556
Fixes #3088

@pomadchin
Copy link
Member Author

@bcb44-esri could you check if the fix works for you? I added a test on this specific file attached.

@pomadchin pomadchin added the bug label Jan 4, 2025
@pomadchin pomadchin merged commit a9f2d0c into locationtech:master Jan 4, 2025
6 checks passed
@pomadchin pomadchin deleted the bug/unknown-tags-skip branch January 4, 2025 04:54
@bcb44-esri
Copy link

@bcb44-esri could you check if the fix works for you? I added a test on this specific file attached.

That works for me, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiff with Unknown Tag causes TiffTag parsing to break
2 participants