Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to AttributesParser so it can be reused #240

Open
wants to merge 1 commit into
base: new-attribute-parser
Choose a base branch
from

Conversation

sebastienbeau
Copy link
Contributor

@did I need to reuse some code of the with_scope so I move it into AttributeParser

@did
Copy link
Member

did commented Oct 1, 2024

@did I need to reuse some code of the with_scope so I move it into AttributeParser

The evaluate_attributes method from the SimpleAttributesParser class (used to be called AttributesParser) has a different method signature AND it stores the results in the @attributes instance variable.

But the evaluate_attributes from the AttributesParser class(used by with_scope) doesn't do that.

And I'm concerned by the lax option and I don't think how it could act in the new evaluate_attributes method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants