Skip to content

Overwrite weight by config user before environment weight validation#2971

Closed
tdadela wants to merge 3 commits intolocustio:masterfrom
tdadela:overwrite-weight-by-config-user-before-environment-weight-validation
Closed

Overwrite weight by config user before environment weight validation#2971
tdadela wants to merge 3 commits intolocustio:masterfrom
tdadela:overwrite-weight-by-config-user-before-environment-weight-validation

Conversation

@tdadela
Copy link
Copy Markdown
Contributor

@tdadela tdadela commented Nov 7, 2024

Current order:

  1. Removing user classes with weight zero. (_remove_user_classes_with_weight_zero()).
  2. Overwriting weights of user classes by CL config.

New order:

  1. Overwriting weights of user classes by CL config.
  2. Removing user classes with weight zero. (_remove_user_classes_with_weight_zero()).

Related to: #2852.

@cyberw
Copy link
Copy Markdown
Collaborator

cyberw commented Nov 24, 2024

Looks ok. Can you add some sort of test case that shows why this was needed/what benefit it provides?

@cyberw
Copy link
Copy Markdown
Collaborator

cyberw commented Jan 7, 2025

*poke* ;)

@cyberw cyberw added the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Jan 7, 2025
@github-actions
Copy link
Copy Markdown

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions Bot closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants