Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from product:pro to tier:pro in config.go #1697

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

deniseschannon
Copy link
Contributor

Fixes ENG-3269

Adding in more comments on which are pro features

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit f5b0b24
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/661ed8b5c48f780008fc6fb7

@heiko-braun
Copy link
Contributor

@deniseschannon Looks good, but I wonder what other code places need to be changed that currently expect product: pro?

@deniseschannon
Copy link
Contributor Author

@heiko-braun nowhere else as it was only used in this file right before v0.20 beta was released. The “addProToJSONSchema” function was added very recently so that the json schema has the pro tag. Afterwards the json schema is used in the docs repo to generate the Config references which we refer to as “partials”.

I wanted to update how we update the json schema to use tier: pro instead of pro:true but it wasn’t a priority for me. It would require way more time on my end as I’m a bit rusty on my development skills to change it in here and then how it’s fed and used in the docs repo. When we work on the automation of the schema changes into the docs repo, we should fix it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants