fix(servicesync): correctly set service clusterIP #2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
…ce.Spec.ClusterIP
|
@FabianKramm Please review this pr, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve?
#1926
Please provide a short message that should be published in the vcluster release notes
When I use syncer
--map-host-serviceargs to sync the serivce from the physical k8s cluster inside vcluster, the ClusterIP is None, which is present in every version of vcluster.So I modified
servicesync.goand built the image locally and tested it on a production vcluster and it works, synchronizing both the headless service and the clusterIP serivce.Note that
ClusterIP: fromService.Spec.ClusterIPis sufficient, there is no need to determine iffromService.Spec.ClusterIPiscorev1.ClusterIPNone.