Skip to content

Conversation

cbalan
Copy link

@cbalan cbalan commented Sep 17, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #ENG-4853

Please provide a short message that should be published in the vcluster release notes
Let the user know that the login credentials are stored in the local vcluster config. Mainly relevant for new users who might attempt to reuse an instance(e.g. delete the cluster, deploy another). The Platform login details of persists.

@cbalan cbalan requested a review from a team as a code owner September 17, 2025 12:39
Copy link
Contributor

@lizardruss lizardruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question, but should get opinions from Denise / Sowmya

@cbalan cbalan force-pushed the eng-4853-platform-login-details-persist-even-if-the-host-cluster-is branch from ae76483 to a1a8bf3 Compare September 23, 2025 08:18
Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this, why is this relevant? When I do docker login it also doesn't tell me my credentials are stored at ~/.docker/config.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants