Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced timelib FromTimeString with dfDateTime #910 #3078

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented Jun 13, 2020

Replaced timelib FromTimeString with dfDateTime #910

@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Jun 13, 2020
@joachimmetz joachimmetz force-pushed the timelib7 branch 4 times, most recently from aba9ad8 to 11005a9 Compare June 20, 2020 09:01
@joachimmetz joachimmetz marked this pull request as ready for review June 20, 2020 09:03
@joachimmetz joachimmetz requested a review from rgayon June 20, 2020 09:03
@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #3078 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
- Coverage   86.28%   86.27%   -0.01%     
==========================================
  Files         399      399              
  Lines       32619    32604      -15     
==========================================
- Hits        28144    28128      -16     
- Misses       4475     4476       +1     
Impacted Files Coverage Δ
plaso/dependencies.py 0.00% <ø> (ø)
plaso/lib/timelib.py 87.50% <ø> (-4.34%) ⬇️
plaso/parsers/java_idx.py 82.95% <66.66%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52e491...67025f3. Read the comment docs.

@joachimmetz joachimmetz removed the blocked Work cannot progress until another issue is resolved label Jun 22, 2020
@joachimmetz joachimmetz added the to merge Issue has been reviewed and can be merged when checks are complete label Jun 23, 2020
@joachimmetz joachimmetz assigned joachimmetz and unassigned rgayon Jun 23, 2020
@joachimmetz joachimmetz merged commit 432a998 into log2timeline:master Jun 23, 2020
@joachimmetz joachimmetz removed the to merge Issue has been reviewed and can be merged when checks are complete label Jun 23, 2020
@joachimmetz joachimmetz deleted the timelib7 branch June 23, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants