Adding custom header support (#188) #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* recreating PR 187 * update changelog * fixed client_options to include custom headers (cherry picked from commit 21de990)
mashhurs
commented
Jan 29, 2025
robbavey
requested changes
Jan 29, 2025
| @@ -24,7 +24,6 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency 'elasticsearch', ">= 7.14.9" # LS >= 6.7 and < 7.14 all used version 5.0.5 | |||
| s.add_runtime_dependency 'manticore', ">= 0.7.1" | |||
| s.add_runtime_dependency 'logstash-mixin-ca_trusted_fingerprint_support', '~> 1.0' | |||
| s.add_runtime_dependency 'logstash-mixin-normalize_config_support', '~>1.0' | |||
There was a problem hiding this comment.
This is still an active dependency in this branch
There was a problem hiding this comment.
Oops, indeed!
I have put it back with d72f5a8 commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreating PR 187
update changelog
fixed client_options to include custom headers
(cherry picked from commit 21de990)
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/