Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added user-defined ack-deadline #24

Closed
wants to merge 4 commits into from
Closed

added user-defined ack-deadline #24

wants to merge 4 commits into from

Conversation

josephlewis42
Copy link
Contributor

No description provided.

@josephlewis42
Copy link
Contributor Author

@amrmotan would you be willing to check if this works for you and meets your needs for #21?

@amrmotan
Copy link

@josephlewis42 Thanks for working on that.
I will reply back once I test it.

@jsvd jsvd requested a review from colinsurprenant April 17, 2018 14:49
@colinsurprenant
Copy link
Contributor

LGTM but not tested locally, did you complete your tests @amrmotan ? I'll go ahead and approve the review but would prefer we wait for @amrmotan feedback before merging.

@amrmotan
Copy link

@colinsurprenant Sorry not yet. Hopefully, I will get the time to test it before the end of today.
I'll keep you posted.

@josephlewis42 josephlewis42 mentioned this pull request Apr 25, 2018
Merged
@josephlewis42
Copy link
Contributor Author

@amrmotan have you had a chance to test this out yet?

@josephlewis42 josephlewis42 closed this by deleting the head repository Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinsurprenant colinsurprenant colinsurprenant approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephlewis42 @amrmotan @colinsurprenant @jsvd