Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace snmptrap ruby-snmp implementation with SNMP4J #5

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Replace snmptrap ruby-snmp implementation with SNMP4J #5

merged 7 commits into from
Apr 5, 2024

Conversation

edmocosta
Copy link
Contributor

@edmocosta edmocosta commented Mar 11, 2024 •
edited
Loading

Changelog:

  • Migrated logstash-input-snmptrap client from ruby-snmp to SNMP4J
  • The event message content was changed from the ruby SNMP::SNMPv1_Trap object inspect representation
    to a hash dump based on the SNMP RFC definition. It also adds those fields as [@metadata][input][snmptrap][pdu][<name>] metadata so users can use them on the pipeline.
  • Fixed default sha2 auth protocol mapping to AuthHMAC192SHA256

@edmocosta edmocosta changed the title [WIP] Replaced snmptrap ruby-snmp implementation with SNMP4j [WIP] Replace snmptrap ruby-snmp implementation with SNMP4j Mar 11, 2024
@edmocosta edmocosta changed the title [WIP] Replace snmptrap ruby-snmp implementation with SNMP4j [WIP] Replace snmptrap ruby-snmp implementation with SNMP4J Mar 11, 2024
@edmocosta edmocosta force-pushed the replace-snmptrap-ruby-snmp-with-snmp4j branch from 83b444c to 9dc3e14 Compare March 19, 2024 16:42
Base automatically changed from migrate-snmp-input-to-java to main April 2, 2024 08:16
@edmocosta edmocosta changed the base branch from main to migrate-snmp-input-to-java April 2, 2024 08:18
@edmocosta edmocosta changed the base branch from migrate-snmp-input-to-java to main April 2, 2024 08:23
@edmocosta edmocosta changed the base branch from main to migrate-snmp-input-to-java April 2, 2024 08:40
@edmocosta edmocosta changed the base branch from migrate-snmp-input-to-java to main April 2, 2024 09:06
@edmocosta edmocosta force-pushed the replace-snmptrap-ruby-snmp-with-snmp4j branch from 9dc3e14 to 0e291af Compare April 2, 2024 09:07
@edmocosta edmocosta changed the title [WIP] Replace snmptrap ruby-snmp implementation with SNMP4J Replace snmptrap ruby-snmp implementation with SNMP4J Apr 2, 2024
@edmocosta edmocosta marked this pull request as ready for review April 2, 2024 09:26
@edmocosta edmocosta requested a review from jsvd April 2, 2024 09:26
jsvd
jsvd reviewed Apr 3, 2024
View reviewed changes
docs/input-snmptrap.asciidoc Outdated Show resolved Hide resolved
docs/input-snmptrap.asciidoc Outdated Show resolved Hide resolved
docs/input-snmptrap.asciidoc Show resolved Hide resolved
lib/logstash/inputs/snmptrap.rb Outdated Show resolved Hide resolved
lib/logstash/inputs/snmptrap.rb Outdated Show resolved Hide resolved
lib/logstash/inputs/snmptrap.rb Outdated Show resolved Hide resolved
lib/logstash/inputs/snmptrap.rb Outdated Show resolved Hide resolved
@jsvd jsvd self-requested a review April 4, 2024 15:35
jsvd
jsvd approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edmocosta edmocosta merged commit 78232b4 into main Apr 5, 2024
2 checks passed
@edmocosta edmocosta deleted the replace-snmptrap-ruby-snmp-with-snmp4j branch May 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmocosta @jsvd