Corrected documentation for action => update
#881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that the "update a document if not already present" only works with the `doc_as_upsert` option. The `upsert` option adds data to the document if the document does not exist I think. Some more explicit documentation for both `upsert` and `doc_as_upsert` would also be helpful
|
@robbavey Please verify the content, and I'll do the rest. Thanks! |
robbavey
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
@karenzone Change LGTM, but as @robin13 mentions, this bit of documentation could do with a little more clarity
3 tasks
karenzone
approved these changes
Oct 8, 2019
|
Added secondary request for "more explicit documentation for both upsert and doc_as_upsert" in #885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the "update a document if not already present" only works with the
doc_as_upsertoption. Theupsertoption adds data to the document if the document does not exist I think.Some more explicit documentation for both
upsertanddoc_as_upsertwould also be helpful