Skip to content

Conversation

thomasreiser
Copy link

Set listen_port to 990.

Set listen_port to 990
@thomasreiser
Copy link
Author

Hi @loicmathieu,

could you maybe also add the hacktoberfest tag? :-)

@loicmathieu
Copy link
Owner

@thomasreiser what's the rational behind this change.
I used implicit ftps without it and it works

@trvboro
Copy link

trvboro commented Nov 24, 2020

The rational is that the default port for implicit ftps is 990. But you can remap the port in port mappings too.

@loicmathieu
Copy link
Owner

If it's the default, it don't needs to be specify in the configuration right ?

Maybe I'm missing something but you just propose to define the default in the config file, this is not something I would do as the config file currently only contains the values that differs from the default.

@trvboro
Copy link

trvboro commented Nov 30, 2020

My bad, I was not very clear. The port tcp/990 is reserved for ftps by IANA (https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml). That's what I meant. But it is not default for ftps in vsftpd. You need to explicitly set it.

@loicmathieu
Copy link
Owner

So it's a breaking change !
I'd rather use port binding for this. If I knew it before I'll used 990 but know I prefere not to break backward compatibility.

My takes on this is if you want more flexible configuration, you can mount a filesystem to override the configuration files embedded inside the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants