DXP-320 Replace Prisma with Drizzle #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Nov 14, 2024
package.json
Outdated
| "@scalar/fastify-api-reference": "^1.25.61", | ||
| "@supercharge/promise-pool": "^3.2.0", | ||
| "amqplib": "^0.10.4", | ||
| "awilix": "^12.0.3", | ||
| "awilix-manager": "^5.5.0", | ||
| "bullmq": "^5.25.4", | ||
| "dotenv": "^16.4.5", |
There was a problem hiding this comment.
is it inevitable? can we use native node env support?
There was a problem hiding this comment.
Yeah, we should definitely be able to avoid this. I've followed Drizzle's instructions for installation but something has changed and they are squeezing in dotenv in the recommended instructions, but it looks like it's not strictly needed. Maestro doesn't have it and works fine. I'll remove it!
dariacm
force-pushed
the
DXP-320_replace_prisma_with_drizzle
branch
from
04a1f31
to
96b228b
Compare
kibertoad
reviewed
Nov 15, 2024
| }, | ||
| }) | ||
| } | ||
| drizzle: asFunction( |
There was a problem hiding this comment.
does it need to be closed at the app shutdown?
kibertoad
reviewed
Nov 15, 2024
| await delegate.deleteMany() | ||
| function getSchemaForModel(model: DB_MODEL): string { | ||
| switch (model) { | ||
| case DB_MODEL.User: |
There was a problem hiding this comment.
is it possible to avoid manual enumeration here? does drizzle provide something we can iterate over?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.