-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #163 - Added footer #164
Conversation
test link: http://loklakapps.surge.sh/ @SKrPl @kavithaenair open for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The "create loklak app" link simply goes to Github. I would expect a tutorial at this link. We don't have that now, therefore, please take this out.
- The bottom bar should be same as on loklak.net. Please implement the same bar and ensure the alignments are correct. Right now the alignment of the right side menu is not matching.
2dbf26c
to
3671209
Compare
Footer no longer visible on test page. |
As @mariobehling said, the test link is not showing the footer anymore. @djmgit please look into it. |
@kavithaenair I have removed it, due to some glitches, I am working on it, will update the PR ASAP |
@kavithaenair @Achint08 @SKrPl updated my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djmgit As you can see that the footer starts from the middle of the screen and moves as the content loads. This is not at all ideal, Make sure the footer starts at the bottom. I don't know how the page is getting the data items, and why there is content adjustment dynamically, this is not at all pleasing, we can have a separate issue for this, but for now, let's make the footer start at bottom and not at the middle of the screen
@hemantjadon sure, I will fix it. |
Fixes issue loklak#163. The main page now contains a footer and store listing page now contains a footer.
@hemantjadon updated PR |
@djmgit: The changes look good. Please resolve conflicts and rebase. |
@djmgit Is the link also updated? I dont think it is, It is still showing moving footer. |
@hemantjadon strange!! I have updated the link, I tested it on chrome and firefox, the footer is not appearing in the middle, even if it appears (is some one scrolls the page while loading), it appears right at the bottom. Which browser are you using? Could you please also test the details page? |
@djmgit There are some merge conflicts, and I also can't see footer in both homepage and app's details page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Please resolve conflicts.
@djmgit Am I checking the wrong link? http://loklakapps.surge.sh/ |
@hemantjadon yeah, that is the current link, which browser are you using?? |
@djmgit I am using Chrome 59 |
@djmgit It is blinking for me. OSX Firefox. |
Okay, I guess this is due to compatibility issues across various browsers. Closing it for now, will be working on it later. |
Short description
Fixes issue #163. The main page now contains a footer.
I have:
Fixes #<number> commit message
For the reviewers
I have: