-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WorldMoodTracker] Add streaming feature #315
base: master
Are you sure you want to change the base?
Conversation
@Achint08 @djmgit @hemantjadon @kavithaenair @SKrPl @vibhcool: Please review. |
if (this.eventSource) { | ||
return; | ||
} | ||
// this.eventSource = new EventSource(host + '/api/stream.json?channel=' + 'all'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djmgit: Removed the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App is displaying tweets, nice work 👍 Please see my comment inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kavithaenair: You can click the area between the modal and address bar to hide it. |
@singhpratyush the modal is not being properly displayed on mobile screen. |
@djmgit: Could you please share the display size? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me. but shouldn't the host link be set to Loklak?
@vibhcool: Currently, streaming is not enabled for the main deployments of loklak. That's why I am using this deployment. |
Also in your subsequent PRs can you put a close button on your modal? I guess it would improve the UX as the area to click on in order to hide the modal is very less :) |
13e4581
to
138c2e3
Compare
@djmgit: Made the changes. @Achint08 @hemantjadon @kavithaenair @SKrPl @vibhcool: Please review. |
link isn't working 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @singhpratyush :)
This is all great, but we don't have reliable search results that the server provides. Therefore the service works unreliably. Please help to make all GSoc projects a success and ensure everyone passes. The pre-requisite for this is: The search results need to work reliably. |
e17757f
to
49e6426
Compare
@mariobehling: We've increased the timeout in order to get better search results in the server. But this pull request is not related to the search results in any way. Please merge this. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine
Short description
Fixes #314.
Changes:
Link: https://singhpratyush.github.io/world-mood-tracker/index.html
Screenshots for the change:
I have:
Fixes #<number> commit message
For the reviewers
I have: